Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update crashpad 2023-11-24 #912

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

supervacuus
Copy link
Collaborator

This fixes #907 + includes the ARM64 build fix from @compnerd.

I also updated and tested this in the context of #900 to verify that the observed behavior wasn't a temporary regression.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #912 (719d3a6) into master (671acff) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   82.60%   82.59%   -0.02%     
==========================================
  Files          53       53              
  Lines        7376     7376              
  Branches     1185     1185              
==========================================
- Hits         6093     6092       -1     
  Misses       1175     1175              
- Partials      108      109       +1     

@supervacuus supervacuus merged commit d88cd76 into master Nov 28, 2023
20 checks passed
@supervacuus supervacuus deleted the chore/update_crashpad_2023_11_24 branch November 28, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-native -> external/crashpad -> third_party/zlib is out of date
2 participants