-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add llvm-mingw #797
[CI] Add llvm-mingw #797
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
==========================================
- Coverage 81.21% 81.18% -0.03%
==========================================
Files 53 53
Lines 6947 6947
Branches 1112 1112
==========================================
- Hits 5642 5640 -2
- Misses 1195 1196 +1
- Partials 110 111 +1 |
b031197
to
1ab2679
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @past-due!
Please let me also be clear about what this CI addition means in terms of maintenance responsibility:
- the responsibility to fix issues concerning MinGW crashpad support still lies with the community
- if the build fails, we will create an issue tagging whoever is interested (I would certainly tag you @past-due)
- if no one is found who has the time to fix the issue, we will deactivate the build so as not to block progress on topics orthogonal to MinGW
- if no one fixed the issue until the next release, the changelog will contain a note that the MinGW support for crashpad is broken (referencing the tracking issue)
@Swatinem, let us finish the remaining crashpad updates in a separate PR and remove the submodule update here.
8ce35e6
to
9ca3807
Compare
9ca3807
to
b8bfd59
Compare
b8bfd59
to
299a50a
Compare
Sounds great. 👍 Please feel free to tag me if / when any future breakages happen. |
Add llvm-mingw CI pass.
Depends on:
mingw compilation fixes crashpad#78Fixes for mingw builds (+ ARM64) #794