Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add llvm-mingw #797

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

past-due
Copy link
Contributor

@past-due past-due commented Jan 27, 2023

@past-due past-due changed the title [CI] Add llvm-mingw [WIP] [CI] Add llvm-mingw Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #797 (299a50a) into master (596260c) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   81.21%   81.18%   -0.03%     
==========================================
  Files          53       53              
  Lines        6947     6947              
  Branches     1112     1112              
==========================================
- Hits         5642     5640       -2     
- Misses       1195     1196       +1     
- Partials      110      111       +1     

@past-due past-due marked this pull request as ready for review February 7, 2023 00:58
@past-due past-due changed the title [WIP] [CI] Add llvm-mingw [CI] Add llvm-mingw Feb 7, 2023
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @past-due!

Please let me also be clear about what this CI addition means in terms of maintenance responsibility:

  • the responsibility to fix issues concerning MinGW crashpad support still lies with the community
  • if the build fails, we will create an issue tagging whoever is interested (I would certainly tag you @past-due)
  • if no one is found who has the time to fix the issue, we will deactivate the build so as not to block progress on topics orthogonal to MinGW
  • if no one fixed the issue until the next release, the changelog will contain a note that the MinGW support for crashpad is broken (referencing the tracking issue)

@Swatinem, let us finish the remaining crashpad updates in a separate PR and remove the submodule update here.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@supervacuus
Copy link
Collaborator

CC: @bitsandfoxes @markushi

@past-due
Copy link
Contributor Author

past-due commented Feb 7, 2023

Please let me also be clear about what this CI addition means in terms of maintenance responsibility:

  • the responsibility to fix issues concerning MinGW crashpad support still lies with the community
  • if the build fails, we will create an issue tagging whoever is interested (I would certainly tag you @past-due)
  • if no one is found who has the time to fix the issue, we will deactivate the build so as not to block progress on topics orthogonal to MinGW
  • if no one fixed the issue until the next release, the changelog will contain a note that the MinGW support for crashpad is broken (referencing the tracking issue)

Sounds great. 👍

Please feel free to tag me if / when any future breakages happen.

@supervacuus supervacuus merged commit 41487ca into getsentry:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants