fix: Be more defensive around transactions #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a bunch more NULL-checks for the outer opaque transaction/_ctx and span types. Also removes the `span_free` function which was pretty much duplicated with span_decref.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
- Coverage 83.09% 82.94% -0.15%
==========================================
Files 53 53
Lines 5017 5032 +15
Branches 1100 1120 +20
==========================================
+ Hits 4169 4174 +5
- Misses 737 746 +9
- Partials 111 112 +1 |
supervacuus
approved these changes
Sep 29, 2022
|
LGTM, danger is still complaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bunch more NULL-checks for the outer opaque transaction/_ctx and span types. Also removes the
span_freefunction which was pretty much duplicated with span_decref.