ref: Update black so it stops breaking our CI #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pulling out of draft to see if the windows checks are blockers |
|
heck yeah it isn't, that can be tackled in a different PR |
relaxolotl
changed the title
Swatinem
approved these changes
Mar 30, 2022
flub
approved these changes
Mar 30, 2022
relaxolotl
force-pushed
the
ref/unbreak-black
branch
from
9c3d4ee
to
67cfe48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black is currently causing our CI to fail. A naive bump up to a version that fixes this shouldn't be high risk for us since: a. it's a code formatter and b. we use python for our integration tests.
The tests don't completely pass but I don't believe it's a hard requirement to at least get this change in. Some of the tests are failing for completely unrelated reasons (deprecated windows environments on GitHub) and can/should be fixed in a separate PR just to keep things compartmentalized.