ref: Switch the internal representation of project IDs from ints over to char*s #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Mar 29, 2022
relaxolotl
force-pushed
the
ref/string-project-ids
branch
from
bfb8334
to
8a06fdf
Compare
|
I've rebased the branch off of #692 which is stacked on top of #691 so this can properly run against the CI again. Changes have also been made to reflect the original expectations that served as the underlying motivation for the change; All feedback should be addressed by the new changes. This PR should be ready for a second look. |
Swatinem
approved these changes
Mar 30, 2022
relaxolotl
force-pushed
the
ref/string-project-ids
branch
from
449ea61
to
df990c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like getsentry/sentry-rust#452, this does what it says in the title. This tries to future-proof project IDs as they aren't guaranteed to be numbers forever. Project IDs are now treated as opaque strings, and minimal validation is now applied to them to reflect that fact.
jira breadcrumb: NATIVE-502