Feat: Crashed last run #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Mar 8, 2022
include/sentry.h
Outdated
Comment on lines
1725
to
1728
| * Otherwise, the same information is reported on any subsequent runs. | ||
| * | ||
| * Note: this doesn't change the value of sentry_get_crashed_last_run() yet. | ||
| * However, if sentry_init() is called again, the value will change. |
There was a problem hiding this comment.
This sounds a bit strange, but on second thought it makes sense.
There was a problem hiding this comment.
yeah... on this whole PR I've gone a couple of iterations before arriving at what currently makes the most sense to me.
|
@Swatinem anything that I should doe here to so that it could get merged? |
Swatinem
approved these changes
Mar 9, 2022
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes information on whether the app has crashed on the last run.