Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use monotonic time for timeouts #284

Merged
merged 8 commits into from
Jun 17, 2020
Merged

fix: Use monotonic time for timeouts #284

merged 8 commits into from
Jun 17, 2020

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jun 10, 2020 •
edited
Loading

Adds a new sentry__monotonic_time util which is used for timeouts, and works around connection delays on windows due to localhost resolving to ipv6 by default.

@Swatinem Swatinem requested a review from a team June 10, 2020 13:10
@Mixaill Mixaill mentioned this pull request Jun 12, 2020
Merged
@Swatinem Swatinem mentioned this pull request Jun 17, 2020
Merged
jan-auer
jan-auer approved these changes Jun 17, 2020
View reviewed changes
src/sentry_core.c Outdated Show resolved Hide resolved
@Swatinem Swatinem merged commit f72a004 into master Jun 17, 2020
@Swatinem Swatinem deleted the fix/monotonic-time branch June 17, 2020 09:10
irov pushed a commit to irov/sentry-native that referenced this pull request Jun 17, 2020
@Swatinem @irov
fix: Use monotonic time for timeouts (getsentry#284)
f5e5bf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mixaill Mixaill Mixaill left review comments

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swatinem @Mixaill @jan-auer