feat: expose function to send minidumps #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a new function that will allow for independently created minidumps to be captured by sentry Resolves: #1050
|
vaind
changed the title
|
Thank you @vaind ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
- Coverage 82.65% 82.62% -0.04%
==========================================
Files 53 53
Lines 7680 7717 +37
Branches 1209 1213 +4
==========================================
+ Hits 6348 6376 +28
- Misses 1219 1228 +9
Partials 113 113 |
supervacuus
requested changes
Nov 1, 2024
supervacuus
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
sentry_capture_minidump(const char*)to send an existing minidump.This PR builds on top of #1052 but makes significant API changes so I've made a new PR instead of rewriting the old one.
Note: CI failures seem to be unrelated, see #1069