-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add breadcrumb ringbuffer to avoid O(n) memmove #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
|
JoshuaMoelans
commented
Oct 29, 2024
JoshuaMoelans
commented
Oct 29, 2024
JoshuaMoelans
commented
Oct 29, 2024
supervacuus
reviewed
Oct 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
==========================================
- Coverage 82.63% 82.60% -0.04%
==========================================
Files 53 53
Lines 7660 7680 +20
Branches 1208 1209 +1
==========================================
+ Hits 6330 6344 +14
- Misses 1216 1224 +8
+ Partials 114 112 -2 |
supervacuus
reviewed
Oct 29, 2024
supervacuus
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; we can merge it with minor finishing touches.
supervacuus
approved these changes
Oct 31, 2024
JoshuaMoelans
changed the title
Add breadcrumb ringbuffer to avoid O(n) memmove
feat: add breadcrumb ringbuffer to avoid O(n) memmove
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
(in progress)
decref
test -> add a test that checks reference counts of objects added/overwritten in ringbuffer