Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add breadcrumb ringbuffer to avoid O(n) memmove #1060

Merged
merged 27 commits into from
Nov 4, 2024

Conversation

JoshuaMoelans
Copy link
Member

@JoshuaMoelans JoshuaMoelans commented Oct 24, 2024

Fixes #1006

(in progress)

  • Creating ringbuffer
  • Storing items to ringbuffer
  • Rethink decref test -> add a test that checks reference counts of objects added/overwritten in ringbuffer
  • Extracting items from ringbuffer (by converting back to regular list)
  • Updating docs
  • Updating changelog

@getsentry getsentry deleted a comment from github-actions bot Oct 28, 2024
Copy link

github-actions bot commented Oct 28, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 190a4a5

@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review October 28, 2024 16:24
@JoshuaMoelans JoshuaMoelans marked this pull request as draft October 28, 2024 16:25
src/sentry_value.c Outdated Show resolved Hide resolved
src/sentry_scope.c Outdated Show resolved Hide resolved
src/sentry_scope.c Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (b598af0) to head (190a4a5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   82.63%   82.60%   -0.04%     
==========================================
  Files          53       53              
  Lines        7660     7680      +20     
  Branches     1208     1209       +1     
==========================================
+ Hits         6330     6344      +14     
- Misses       1216     1224       +8     
+ Partials      114      112       -2     

src/sentry_value.c Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans marked this pull request as ready for review October 29, 2024 14:32
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; we can merge it with minor finishing touches.

src/sentry_value.h Outdated Show resolved Hide resolved
src/sentry_scope.c Outdated Show resolved Hide resolved
@JoshuaMoelans JoshuaMoelans changed the title Add breadcrumb ringbuffer to avoid O(n) memmove feat: add breadcrumb ringbuffer to avoid O(n) memmove Nov 4, 2024
@JoshuaMoelans JoshuaMoelans merged commit ffdf6ed into master Nov 4, 2024
26 checks passed
@JoshuaMoelans JoshuaMoelans deleted the feat/breadcrumb_ringbuffer_joshua branch November 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs should use more efficient ringbuffer
2 participants