Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check file-writer construction when writing envelope to path #1036

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Aug 28, 2024

fixes #1035.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (a762b23) to head (e9b664a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
+ Coverage   83.75%   83.78%   +0.02%     
==========================================
  Files          53       53              
  Lines        5510     5512       +2     
  Branches     1197     1198       +1     
==========================================
+ Hits         4615     4618       +3     
+ Misses        782      781       -1     
  Partials      113      113              

@supervacuus supervacuus merged commit 58c3286 into master Aug 28, 2024
23 checks passed
@supervacuus supervacuus deleted the fix/write_envelope_to_invalid_path branch August 28, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV possible via sentry_envelope_write_to_path when path is invalid
2 participants