Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: further dependency export cleanup #1013

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

supervacuus
Copy link
Collaborator

@supervacuus supervacuus commented Jun 19, 2024

  • Use THREADS_PREFER_PTHREAD_FLAG as is recommended.
  • Replace checks for _FOUND variables with checks to actual targets before we find_package() in our build scripts.
  • Ensure that we include the crashpad targets in the export configuration only after all invocations of find_dependency()
  • Remove REQUIRED from the find_dependency() invocations and let it retrieve the value from the find_package() invocations in the build scripts.
  • link _SENTRY_PLATFORM_LIBS only as PRIVATE to target sentry since it sufficiently exports in case of a static build to the consuming project (using LINK_ONLY generator expressions in exported targets).
  • corresponding changes in crashpad.
  • Update submodule reference after the merge in our crashpad fork.

@supervacuus supervacuus force-pushed the fix/further_cmake_deps_cleanup branch from 644367a to 1ec05f5 Compare June 26, 2024 09:59
@supervacuus supervacuus merged commit 6beae6b into master Jun 26, 2024
20 checks passed
@supervacuus supervacuus deleted the fix/further_cmake_deps_cleanup branch June 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants