Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crashpad build for Windows ARM64 via LLVM-MINGW #1003

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

past-due
Copy link
Contributor

@past-due past-due commented Jun 4, 2024

Fixes: #1002.

Actual change: getsentry/crashpad#/101.

@past-due past-due changed the title Update LLVM-mingw dependencies ci: update LLVM-mingw dependencies Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (235f837) to head (be85d31).
Report is 5 commits behind head on master.

Current head be85d31 differs from pull request most recent head 25ef084

Please upload reports for the commit 25ef084 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   86.53%   83.92%   -2.62%     
==========================================
  Files          40       53      +13     
  Lines        3736     5443    +1707     
  Branches        0     1207    +1207     
==========================================
+ Hits         3233     4568    +1335     
- Misses        503      761     +258     
- Partials        0      114     +114     

@past-due past-due changed the title ci: update LLVM-mingw dependencies fix: crashpad build for Windows ARM64 via LLVM-MINGW Jun 5, 2024
@past-due past-due marked this pull request as ready for review June 5, 2024 14:48
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@supervacuus supervacuus merged commit a05b260 into getsentry:master Jun 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Merge getsentry/crashpad PR #101 to fix llvm-mingw arm64 crashpad builds
2 participants