-
-
Notifications
You must be signed in to change notification settings - Fork 19
fix: updater config v2 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Works on |
|
@vaind seems like v2 breaks because of a token thing but v1 works. failure:
Diff is long: getsentry/github-workflows@v1...v2.8.1 (assuming this is what v1 to v2 does) But repo has |
vaind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to roll back, just fix the config, see my pr #172
No need to look at the diff between v1 and the latest v2. The release notes say what changed as the very first item https://github.com/getsentry/github-workflows/releases/tag/v2.0.0
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 27 27
Lines 424 424
Branches 55 55
=======================================
Hits 330 330
Misses 68 68
Partials 26 26 ☔ View full report in Codecov by Sentry. |
#skip-changelog