Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 20, 2023

#skip-changelog

@buenaflor buenaflor changed the title see if it works on @v1 (pr only for testing): check if updater ci works on @v1 Dec 20, 2023
@buenaflor
Copy link
Contributor Author

buenaflor commented Dec 20, 2023

Works on @v1

@getsentry getsentry deleted a comment from codecov bot Dec 20, 2023
@bruno-garcia
Copy link
Member

bruno-garcia commented Dec 20, 2023

@vaind seems like v2 breaks because of a token thing but v1 works.

failure:

The workflow is not valid. .github/workflows/update-deps.yml (Line: 14, Col: 11): Secret api-token is required, but not provided while calling. .github/workflows/update-deps.yml (Line: 20, Col: 18): Invalid secret, api_token is not defined in the referenced workflow.

Diff is long: getsentry/github-workflows@v1...v2.8.1 (assuming this is what v1 to v2 does)
maybe the value was always wrong but didn't get used in v1?
new version has api-token: ${{ secrets.CI_DEPLOY_KEY }}

But repo has CI_DEPLOY_KEY (possibly is empty if I fucked it up somehow

Copy link
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to roll back, just fix the config, see my pr #172

@vaind
Copy link
Contributor

vaind commented Dec 20, 2023

@vaind seems like v2 breaks because of a token thing but v1 works.

failure:

The workflow is not valid. .github/workflows/update-deps.yml (Line: 14, Col: 11): Secret api-token is required, but not provided while calling. .github/workflows/update-deps.yml (Line: 20, Col: 18): Invalid secret, api_token is not defined in the referenced workflow.

Diff is long: getsentry/github-workflows@v1...v2.8.1 (assuming this is what v1 to v2 does) maybe the value was always wrong but didn't get used in v1? new version has api-token: ${{ secrets.CI_DEPLOY_KEY }}

But repo has CI_DEPLOY_KEY (possibly is empty if I fucked it up somehow

No need to look at the diff between v1 and the latest v2. The release notes say what changed as the very first item https://github.com/getsentry/github-workflows/releases/tag/v2.0.0

Rename api_token secret to api-token (getsentry/github-workflows#21)

@buenaflor buenaflor closed this Dec 21, 2023
@buenaflor buenaflor reopened this Dec 21, 2023
@codecov
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96f86a5) 77.83% compared to head (9cad86d) 77.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files          27       27           
  Lines         424      424           
  Branches       55       55           
=======================================
  Hits          330      330           
  Misses         68       68           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor changed the title (pr only for testing): check if updater ci works on @v1 fix: updater config v2 Dec 21, 2023
@buenaflor buenaflor marked this pull request as ready for review December 21, 2023 13:03
@buenaflor buenaflor requested a review from romtsn as a code owner December 21, 2023 13:03
@buenaflor buenaflor merged commit b3622fc into main Dec 21, 2023
@buenaflor buenaflor deleted the ci/check-reverted-updater branch December 21, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants