chore(sveltekit): Add SvelteKit 2.0 to peer dependency range #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mydea
reviewed
Dec 15, 2023
packages/sveltekit/package.json
Outdated
| @@ -17,7 +17,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "peerDependencies": { | |||
| "@sveltejs/kit": "1.x" | |||
| "@sveltejs/kit": ">=1.x" | |||
There was a problem hiding this comment.
To be a bit more cautious, should we make this >= 1 <= 2?
There was a problem hiding this comment.
We can ofc but for example, in Astro, we opted to leave an open end given that we'll need support for a new major anyway (#9683)
There was a problem hiding this comment.
I'd rather we explicitly opt-in to every major version, and make this "@sveltejs/kit": "^1.0 || ^2.0" like what we do for nextjs.
There was a problem hiding this comment.
ok, changed it to an explicit major array. Don't have strong opinions here, so fine with anything 😅
Lms24
force-pushed
the
lms/chore-bump-kit-dependencies
branch
from
6409323
to
48fbe6b
Compare
AbhiPrasad
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the range to
>=1.xto include kit 2.0 and higher1.x || 2.xto include kit 2.0