Skip to content

fix(utils): regex match port to stop accidental replace #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2023
Merged

fix(utils): regex match port to stop accidental replace #9676

merged 3 commits into from
Nov 28, 2023

Conversation

AbhiPrasad
Copy link
Member

also fixes #9673

@AbhiPrasad AbhiPrasad requested review from a team, anonrig and lforst and removed request for a team November 27, 2023 18:34
@AbhiPrasad AbhiPrasad mentioned this pull request Nov 27, 2023
Closed
3 tasks
anonrig
anonrig reviewed Nov 27, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.86 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.46 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.12 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped) 21.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.72 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.53 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.46 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.32 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.29 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.22 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.25 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.42 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 28, 2023 15:31
@AbhiPrasad AbhiPrasad merged commit dd34361 into develop Nov 28, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-fix-port-replace branch November 28, 2023 16:10
@anonrig anonrig mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(bun + hono) "http://172.31.12.14480/ruok" cannot be parsed as a URL.
3 participants
@AbhiPrasad @anonrig @lforst