-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(feedback): Implement new user feedback embeddable widget #9217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
64617df
docs(feedback): Add more themeables + improve/fix inconsistencies
billyvg 493992c
wip: initial widget api
billyvg 9f81fda
wip: refactor to functions
billyvg 916bb62
lint
billyvg 5f5479e
ref: move css into separate fns
billyvg a75e600
ref: move Actor into sep file
billyvg 3e71020
ref: use FeedbackComponent and rename methods
billyvg 9cd810b
feat: add success message, error message, move submit logic up into i…
billyvg bbc26dc
dont typecheck callback fns
billyvg 4097e4b
some svg refactors
billyvg 6a91be8
WIP: Add attachTo configuration
billyvg fbf4e30
fix cENS
billyvg fde0896
try/catch all the things, fix dialog not opening, add autoInject option
billyvg cd8b208
move feedback class to integration.ts, make isAnonymous work, hide fa…
billyvg 725a42f
ref(Form): destructure options in params
billyvg 9e2ce65
ref: move theme/text labels to constants, fix dark mode for svgs
billyvg 9925a87
ref: change/add some callbacks
billyvg 80294ad
ref: fix onDialogOpened, add option for host id
billyvg e4904d8
feat: change positioning css to use css vars
billyvg 9b94658
meta: lint fixes
billyvg c5821d9
use isBrowser
billyvg ff14e8e
ref(feedback): Refactor to better support multiple dialogs (#9305)
billyvg fc5568e
refactor shadow/host creation
billyvg 6dfc0b5
remove $ prefix, change h to createElement
billyvg 30596d6
createElementNS
billyvg 1a85ce6
test feedback in size limit
billyvg 3b5bc77
v0.0.1-alpha.5
billyvg d14ae45
export Form props + add Form test
billyvg 6c532d0
test when message turns empty
billyvg f41ffd1
add actor test + slight refactor, add text label test for form
billyvg 8a820c6
remove referrer
billyvg 3eb963a
explicit props instead of passing options
billyvg edd2a90
add dialog test
billyvg e6c09d2
add submit button test
billyvg 5497c1c
add test for SuccessMessage
billyvg 6bfdbf9
lint
billyvg 02d17c9
add createWidget test, refactor
billyvg 9456f37
ref: remove disabled button, instead add better a11y for required field
billyvg 97ca405
update aria attributes + elements should be in getter
billyvg 6b6ca10
fix type for attachTo
billyvg 03d10cd
missing callback
billyvg 99ef589
update tests
billyvg c488fcd
lint
billyvg c97d3bb
bump sentry version
billyvg 0897a26
v0.0.1-alpha.6
billyvg 6a951bd
fix(types): Fix optional types for theme
billyvg 5b12a2f
submit/cancel
billyvg 2b12c96
refactor theme names to be even more consistent, add input styles
billyvg 5230bf6
v0.0.1-alpha.7
billyvg fda4cb2
feat: Add Sentry branding
billyvg 7942039
fix outline
billyvg 6d439d5
fix branding
billyvg 5c2682f
fix darkmode firefox
billyvg b9a3c9c
v0.0.1-alpha.8
billyvg 9c02d47
v0.0.1-alpha.9
billyvg cc43a04
review fixes
billyvg aa31d8d
prettier
billyvg 78e6b60
fix ts
billyvg ee46ff4
more ts
billyvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
module.exports = require('../../jest/jest.config.js'); | ||
const baseConfig = require('../../jest/jest.config.js'); | ||
|
||
module.exports = { | ||
...baseConfig, | ||
testEnvironment: 'jsdom', | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
const LIGHT_BACKGROUND = '#ffffff'; | ||
const INHERIT = 'inherit'; | ||
const LIGHT_THEME = { | ||
fontFamily: "'Helvetica Neue', Arial, sans-serif", | ||
fontSize: '14px', | ||
|
||
background: LIGHT_BACKGROUND, | ||
backgroundHover: '#f6f6f7', | ||
foreground: '#2b2233', | ||
border: '1.5px solid rgba(41, 35, 47, 0.13)', | ||
boxShadow: '0px 4px 24px 0px rgba(43, 34, 51, 0.12)', | ||
|
||
success: '#268d75', | ||
error: '#df3338', | ||
|
||
submitBackground: 'rgba(88, 74, 192, 1)', | ||
submitBackgroundHover: 'rgba(108, 95, 199, 1)', | ||
submitBorder: 'rgba(108, 95, 199, 1)', | ||
submitForeground: LIGHT_BACKGROUND, | ||
|
||
cancelBackground: 'transparent', | ||
cancelBackgroundHover: 'var(--background-hover)', | ||
cancelBorder: 'var(--border)', | ||
cancelForeground: 'var(--foreground)', | ||
|
||
inputBackground: INHERIT, | ||
inputForeground: INHERIT, | ||
inputBorder: 'var(--border)', | ||
inputBorderFocus: 'rgba(108, 95, 199, 1)', | ||
}; | ||
|
||
export const DEFAULT_THEME = { | ||
light: LIGHT_THEME, | ||
dark: { | ||
...LIGHT_THEME, | ||
|
||
background: '#29232f', | ||
backgroundHover: '#352f3b', | ||
foreground: '#ebe6ef', | ||
border: '1.5px solid rgba(235, 230, 239, 0.15)', | ||
|
||
success: '#2da98c', | ||
error: '#f55459', | ||
}, | ||
}; | ||
|
||
export const ACTOR_LABEL = 'Report a Bug'; | ||
export const CANCEL_BUTTON_LABEL = 'Cancel'; | ||
export const SUBMIT_BUTTON_LABEL = 'Send Bug Report'; | ||
export const FORM_TITLE = 'Report a Bug'; | ||
export const EMAIL_PLACEHOLDER = 'your.email@example.org'; | ||
export const EMAIL_LABEL = 'Email'; | ||
export const MESSAGE_PLACEHOLDER = "What's the bug? What did you expect?"; | ||
export const MESSAGE_LABEL = 'Description'; | ||
export const NAME_PLACEHOLDER = 'Your Name'; | ||
export const NAME_LABEL = 'Name'; | ||
export const SUCCESS_MESSAGE_TEXT = 'Thank you for your report!'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export { sendFeedbackRequest } from './util/sendFeedbackRequest'; | ||
export { Feedback } from './integration'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.