Remove image transport #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| img.src = src; | ||
| }, | ||
| // if browser doesn't support CORS (e.g. IE7), we are | ||
| // out of luck ... report to console? |
There was a problem hiding this comment.
Unlikely worth it since this would happen to the user, not the person who actually cares about raven-js.
There was a problem hiding this comment.
Yeah, I know. So let's stick with no-op (and I'll amend comment)?
benvinegar
force-pushed
the
remove-image-transport
branch
from
0a942a6 to
8c33296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We basically want everyone to use XHR POST + CORS, which is supported in IE8 and above. We haven't had any trouble w/ people using the XHR transport (which has been the default since 2.0), so we feel confident we can remove the Image transport. We could add it back as a plugin if people really need it, but it wouldn't be advised anyways (since URI length too long limit is frequently hit).