Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Add missing React peer dependency #4576

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix(gatsby): Add missing React peer dependency #4576

merged 1 commit into from
Feb 15, 2022

Conversation

aaronadamsCA
Copy link
Contributor

Fixes #4549 by copying missing React peer dependency from packages/nextjs/package.json.

@aaronadamsCA aaronadamsCA mentioned this pull request Feb 15, 2022
Closed
2 tasks
@AbhiPrasad AbhiPrasad changed the title Add missing Gatsby peer dependency on React fix(gatsby): Add missing React peer dependency Feb 15, 2022
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 15, 2022 15:36
AbhiPrasad
AbhiPrasad approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the liberty of changing the title.

Appreciate the help, thanks for both the PRs!

@AbhiPrasad AbhiPrasad merged commit 0a6e535 into getsentry:master Feb 15, 2022
@aaronadamsCA aaronadamsCA deleted the patch-1 branch February 15, 2022 16:01
@vladanpaunovic vladanpaunovic mentioned this pull request Feb 16, 2022
Merged
@AbhiPrasad AbhiPrasad mentioned this pull request Feb 24, 2022
Closed
@sapjax
Copy link

sapjax commented Apr 2, 2022

This PR causes the dependency conflict with Next.js 12 which has the dependency of react@"^18.0.0".

@AbhiPrasad
Copy link
Member

Next release will fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing peer dependencies in Gatsby package
3 participants
@aaronadamsCA @sapjax @AbhiPrasad