Lazy load plugins #392
Merged
Lazy load plugins #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
force-pushed
the
plugins
branch
2 times, most recently
from
31a16c1 to
89d5bf0
Compare
This defers the installationa nd loading of plugins until `Raven.install()` is called.
| @@ -133,6 +134,12 @@ var Raven = { | |||
| install: function() { | |||
| if (isSetup() && !isRavenInstalled) { | |||
| TraceKit.report.subscribe(handleStackInfo); | |||
|
|
|||
| // Install all of the plugins | |||
| each(plugins, function(_, plugin) { | |||
There was a problem hiding this comment.
Wouldn't it redefine global _ var used by underscore or lodash?
There was a problem hiding this comment.
This would just be a local, and we're not using underscore or lodash inside this loop, so should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defers the installation and loading of plugins until
Raven.install()is called.Should fix up issues around #384 I believe, since it'll be less important.