test(react-router): Fix getMetaTagTransformer tests for Vitest compatibility#18013
Merged
test(react-router): Fix getMetaTagTransformer tests for Vitest compatibility#18013
getMetaTagTransformer tests for Vitest compatibility#18013Conversation
Bug: Test Logic Mismatch: Head Tag Presence Affects Meta InjectionThe test "should not modify chunks without head closing tag" has inconsistent logic. It provides HTML with a |
e2557af to
5d76a7f
Compare
onurtemizkan
approved these changes
Oct 23, 2025
chargome
approved these changes
Oct 23, 2025
71f1fb6 to
d44cc20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
donecallback to Promise-based async test pattern</head>tag to triggergetTraceMetaTagscall (the test did not work before asgetTraceMetaTagsis only called when there is a closingheadtagThe getMetaTagTransformer function internally pipes the transformer TO the bodyStream (
htmlMetaTagTransformer.pipe(body)). So the correct flow is: