feat(cloudflare): Add honoIntegration with error-filtering function#17743
Merged
feat(cloudflare): Add honoIntegration with error-filtering function#17743
honoIntegration with error-filtering function#17743Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
s1gr1d
commented
Sep 23, 2025
| import baseConfig from '../../vite/vite.config'; | ||
|
|
||
| export default defineConfig({ | ||
| ...baseConfig, |
Member
Author
There was a problem hiding this comment.
I needed to add a vite.config.ts file because the baseConfig defines this:
define: {
__DEBUG_BUILD__: true,
},
...and this was needed to make the unit tests work.
mydea
reviewed
Sep 24, 2025
mydea
reviewed
Sep 24, 2025
mydea
reviewed
Sep 24, 2025
cf3207d to
e910c66
Compare
mydea
approved these changes
Sep 24, 2025
3 tasks
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
6 tasks
s1gr1d
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 20, 2025
## DESCRIBE YOUR PR This adds docs for this PR: getsentry/sentry-javascript#17743 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
honoIntegrationthat exposes ashouldHandleErrorfunction that lets users define a custom handling of capturing errors. By default, we capture allErrors and if the error includes astatuswe capture exceptions witherror.status >= 500 || error.status <= 299.It's possible to modify this behavior like this:
Up for discussion: The function name is the same like in express/fastify to keep it consistent. But I was also thinking about other names like
shouldHandleInOnErrororshouldCaptureOnError🤔 Because it's specifically about theonErrorfunction. Let me know what you think.closes #17717