build: Update TS target to es2020 everywhere#17709
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
mydea
force-pushed
the
fn/use-es2020
branch
from
4667808 to
48ccf52
Compare
There was a problem hiding this comment.
m: This concerns all e2e tests: I think it'd make more sense to keep the target at the respective framework's default. If nothing else, this should help us identify incompatibilities that likely also surface in users' apps. WDYT?
There was a problem hiding this comment.
I think this generally is true and we do not need to keep all of these in sync/at latest always. I figured it's OK to adjust this once but no strong feeling, can also keep them as they were!
There was a problem hiding this comment.
reverted the e2e test changes :)
| "target": "es2020", | ||
| "declarationMap": false, | ||
| "lib": ["DOM", "ES2018"], | ||
| "lib": ["DOM", "es2020"], |
There was a problem hiding this comment.
good catch! Turns out we could have done this a lot sooner for Angular, ever since we switched to NG14 as the min version (https://v14.angular.io/guide/angular-package-format#es2020-language-level).
mydea
force-pushed
the
fn/use-es2020
branch
2 times, most recently
from
447bfa0 to
4f534cf
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mydea
force-pushed
the
fn/use-es2020
branch
from
0f60f63 to
deb5889
Compare
mydea
force-pushed
the
fn/use-es2020
branch
from
deb5889 to
fb31cc3
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/use-es2020
branch
from
fb31cc3 to
96b9292
Compare
2 participants
We already officially only support es2020, so we may as well also use this as lib & target everywhere.