feat(core): Create template attributes in consoleLoggingIntegration#17703
Merged
AbhiPrasad merged 2 commits intodevelopfrom Sep 19, 2025
Merged
feat(core): Create template attributes in consoleLoggingIntegration#17703AbhiPrasad merged 2 commits intodevelopfrom
consoleLoggingIntegration#17703AbhiPrasad merged 2 commits intodevelopfrom
Conversation
consoleLoggingIntegration
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Sep 19, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
Can see how this is useful. Sounds like a good change to me!
| }); | ||
|
|
||
| return attributes; | ||
| } |
There was a problem hiding this comment.
Bug: Console Template Attributes Formatting Issues
The createConsoleTemplateAttributes function has two issues. The sentry.message.template attribute includes an unintended trailing space when no followingArgs are present. Additionally, sentry.message.parameter attributes are stored as raw values instead of structured objects with value/type, and null/undefined values are not converted to their expected string representations.
AbhiPrasad
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Sep 25, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #16737
Right now if users use
console.loglike so:The console logging integration will emit a log with log message
"here is my log statement".Some users would like it if we automatically paramaterized this into a template, given there are separate arguments being sent into the logging statement. So the above log statement would generate
{ "sentry.message.template": "here {} {} {} {}", "sentry.message.parameter.0": "is", "sentry.message.parameter.1": "my", "sentry.message.parameter.2": "log", "sentry.message.parameter.3": "statement", }This paramaterization is what this PR does, which provides a much better user experience.
One edge case that we need to watch out for is console substitution patterns like
%s,%d,%i,%f,%o,%O,%c. Read more about this in the MDN docs. When encountering a console substitution pattern in the string, we elect to not generate string templates, as parsing the string to evaluate it gets too complicated client side.