ref(core): Streamline module_metadata assignment and cleanup functions#17696
Merged
ref(core): Streamline module_metadata assignment and cleanup functions#17696
module_metadata assignment and cleanup functions#17696Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
commented
Sep 18, 2025
| name: 'ThirdPartyErrorsFilter', | ||
| setup(client) { | ||
| // We need to strip metadata from stack frames before sending them to Sentry since these are client side only. | ||
| // TODO(lforst): Move this cleanup logic into a more central place in the SDK. |
Member
Author
There was a problem hiding this comment.
I decided to remove this TODO because for now, we only call this cleanup in the two optional integrations. So moving this to client would allow us to get rid of the double-hook registration but at the same time penalize the core bundle size for something users likely don't use. We can revisit and extract it once this logic is used in a default integration but I don't think there's much benefit in doing it now.
Lms24
changed the title
stripMetadataFromStackFrames calls
Lms24
changed the title
module_metadata assignment and cleanup functions
Lms24
requested review from
a team,
RulaKhaled and
mydea
and removed request for
a team
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick PR to streamline the stack frame
module_metadataproperty assignment (addMetadataToStackFrames) and cleanup (stripMetadataFromStackFrames) logic, since we can use optional chaining now without a bundle size hit from polyfilling.Originally went with moving the cleanup logic into the client but decided against it due to the bundle size hit (see comment).