CLOSED - add node support for generic featureFlagsIntegration and move utils to core

.size-limit.js

@@ -120,7 +120,7 @@ module.exports = [
     import: createImport('init', 'ErrorBoundary', 'reactRouterV6BrowserTracingIntegration'),
     ignore: ['react/jsx-runtime'],
     gzip: true,
-    limit: '40.5 KB',
+    limit: '41 KB',
   },
   // Vue SDK (ESM)
   {
@@ -215,7 +215,7 @@ module.exports = [
     import: createImport('init'),
     ignore: ['$app/stores'],
     gzip: true,
-    limit: '39 KB',
+    limit: '40 KB',
   },
   // Node SDK (ESM)
   {

CHANGELOG.md

@@ -4,6 +4,31 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
+## 9.29.0
+
+### Important Changes
+
+- **feat(browser): Update `web-vitals` to 5.0.2 ([#16492](https://github.com/getsentry/sentry-javascript/pull/16492))**
+
+This release upgrades the `web-vitals` library to version 5.0.2. This upgrade could slightly change the collected web vital values and potentially also influence alerts and performance scores in the Sentry UI.
+
+### Other Changes
+
+- feat(deps): Bump @sentry/rollup-plugin from 3.4.0 to 3.5.0 ([#16524](https://github.com/getsentry/sentry-javascript/pull/16524))
+- feat(ember): Stop warning for `onError` usage ([#16547](https://github.com/getsentry/sentry-javascript/pull/16547))
+- feat(node): Allow to force activate `vercelAiIntegration` ([#16551](https://github.com/getsentry/sentry-javascript/pull/16551))
+- feat(node): Introduce `ignoreLayersType` option to koa integration ([#16553](https://github.com/getsentry/sentry-javascript/pull/16553))
+- fix(browser): Ensure `suppressTracing` does not leak when async ([#16545](https://github.com/getsentry/sentry-javascript/pull/16545))
+- fix(vue): Ensure root component render span always ends ([#16488](https://github.com/getsentry/sentry-javascript/pull/16488))
+
+## 9.28.1
+
+- feat(deps): Bump @sentry/cli from 2.45.0 to 2.46.0 ([#16516](https://github.com/getsentry/sentry-javascript/pull/16516))
+- fix(nextjs): Avoid tracing calls to symbolication server on dev ([#16533](https://github.com/getsentry/sentry-javascript/pull/16533))
+- fix(sveltekit): Add import attribute for node exports ([#16528](https://github.com/getsentry/sentry-javascript/pull/16528))
+
+Work in this release was contributed by @eltigerchino. Thank you for your contribution!
+
 ## 9.28.0
 
 ### Important Changes

dev-packages/browser-integration-tests/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry-internal/browser-integration-tests",
-  "version": "9.28.0",
+  "version": "9.29.0",
   "main": "index.js",
   "license": "MIT",
   "engines": {
@@ -42,7 +42,7 @@
     "@babel/preset-typescript": "^7.16.7",
     "@playwright/test": "~1.50.0",
     "@sentry-internal/rrweb": "2.34.0",
-    "@sentry/browser": "9.28.0",
+    "@sentry/browser": "9.29.0",
     "@supabase/supabase-js": "2.49.3",
     "axios": "1.8.2",
     "babel-loader": "^8.2.2",

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/onError/basic/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/onSpan/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
 import { sentryTest } from '../../../../../utils/fixtures';
 import {
   type EventAndTraceHeader,
@@ -7,7 +8,6 @@ import {
   shouldSkipFeatureFlagsTest,
   shouldSkipTracingTest,
 } from '../../../../../utils/helpers';
-import { MAX_FLAGS_PER_SPAN } from '../../constants';
 
 sentryTest("Feature flags are added to active span's attributes on span end.", async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest() || shouldSkipTracingTest()) {
@@ -58,12 +58,9 @@ sentryTest("Feature flags are added to active span's attributes on span end.", a
   expect(innerSpanFlags).toEqual([]);
 
   const expectedOuterSpanFlags = [];
-  for (let i = 1; i <= 2; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
+  for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
+    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, i === 3]);
   }
-  for (let i = 4; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
-  }
-  expectedOuterSpanFlags.push(['flag.evaluation.feat3', true]);
-  expect(outerSpanFlags).toEqual(expectedOuterSpanFlags);
+  // Order agnostic (attribute dict is unordered).
+  expect(outerSpanFlags.sort()).toEqual(expectedOuterSpanFlags.sort());
 });

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/onError/basic/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/onSpan/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
 import { sentryTest } from '../../../../../utils/fixtures';
 import {
   type EventAndTraceHeader,
@@ -7,7 +8,6 @@ import {
   shouldSkipFeatureFlagsTest,
   shouldSkipTracingTest,
 } from '../../../../../utils/helpers';
-import { MAX_FLAGS_PER_SPAN } from '../../constants';
 
 sentryTest("Feature flags are added to active span's attributes on span end.", async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest() || shouldSkipTracingTest()) {
@@ -58,12 +58,9 @@ sentryTest("Feature flags are added to active span's attributes on span end.", a
   expect(innerSpanFlags).toEqual([]);
 
   const expectedOuterSpanFlags = [];
-  for (let i = 1; i <= 2; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
+  for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
+    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, i === 3]);
   }
-  for (let i = 4; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
-  }
-  expectedOuterSpanFlags.push(['flag.evaluation.feat3', true]);
-  expect(outerSpanFlags).toEqual(expectedOuterSpanFlags);
+  // Order agnostic (attribute dict is unordered).
+  expect(outerSpanFlags.sort()).toEqual(expectedOuterSpanFlags.sort());
 });

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/onError/basic/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/onError/errorHook/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Flag evaluation error hook', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/onSpan/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
 import { sentryTest } from '../../../../../utils/fixtures';
 import {
   type EventAndTraceHeader,
@@ -7,7 +8,6 @@ import {
   shouldSkipFeatureFlagsTest,
   shouldSkipTracingTest,
 } from '../../../../../utils/helpers';
-import { MAX_FLAGS_PER_SPAN } from '../../constants';
 
 sentryTest("Feature flags are added to active span's attributes on span end.", async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest() || shouldSkipTracingTest()) {
@@ -58,12 +58,9 @@ sentryTest("Feature flags are added to active span's attributes on span end.", a
   expect(innerSpanFlags).toEqual([]);
 
   const expectedOuterSpanFlags = [];
-  for (let i = 1; i <= 2; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
+  for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
+    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, i === 3]);
   }
-  for (let i = 4; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
-  }
-  expectedOuterSpanFlags.push(['flag.evaluation.feat3', true]);
-  expect(outerSpanFlags).toEqual(expectedOuterSpanFlags);
+  // Order agnostic (attribute dict is unordered).
+  expect(outerSpanFlags.sort()).toEqual(expectedOuterSpanFlags.sort());
 });

dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/onError/basic/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/onSpan/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
 import { sentryTest } from '../../../../../utils/fixtures';
 import {
   type EventAndTraceHeader,
@@ -7,7 +8,6 @@ import {
   shouldSkipFeatureFlagsTest,
   shouldSkipTracingTest,
 } from '../../../../../utils/helpers';
-import { MAX_FLAGS_PER_SPAN } from '../../constants';
 
 sentryTest("Feature flags are added to active span's attributes on span end.", async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest() || shouldSkipTracingTest()) {
@@ -62,12 +62,9 @@ sentryTest("Feature flags are added to active span's attributes on span end.", a
   expect(innerSpanFlags).toEqual([]);
 
   const expectedOuterSpanFlags = [];
-  for (let i = 1; i <= 2; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
+  for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
+    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, i === 3]);
   }
-  for (let i = 4; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
-  }
-  expectedOuterSpanFlags.push(['flag.evaluation.feat3', true]);
-  expect(outerSpanFlags).toEqual(expectedOuterSpanFlags);
+  // Order agnostic (attribute dict is unordered).
+  expect(outerSpanFlags.sort()).toEqual(expectedOuterSpanFlags.sort());
 });

dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/onError/basic/test.ts

@@ -1,11 +1,11 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_FLAG_BUFFER_SIZE as FLAG_BUFFER_SIZE } from '@sentry/core';
 import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   shouldSkipFeatureFlagsTest,
   waitForErrorRequest,
 } from '../../../../../../utils/helpers';
-import { FLAG_BUFFER_SIZE } from '../../../constants';
 
 sentryTest('Basic test with eviction, update, and no async tasks', async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest()) {

dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/onSpan/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import { _INTERNAL_MAX_FLAGS_PER_SPAN as MAX_FLAGS_PER_SPAN } from '@sentry/core';
 import { sentryTest } from '../../../../../utils/fixtures';
 import {
   type EventAndTraceHeader,
@@ -7,7 +8,6 @@ import {
   shouldSkipFeatureFlagsTest,
   shouldSkipTracingTest,
 } from '../../../../../utils/helpers';
-import { MAX_FLAGS_PER_SPAN } from '../../constants';
 
 sentryTest("Feature flags are added to active span's attributes on span end.", async ({ getLocalTestUrl, page }) => {
   if (shouldSkipFeatureFlagsTest() || shouldSkipTracingTest()) {
@@ -60,12 +60,9 @@ sentryTest("Feature flags are added to active span's attributes on span end.", a
   expect(innerSpanFlags).toEqual([]);
 
   const expectedOuterSpanFlags = [];
-  for (let i = 1; i <= 2; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
+  for (let i = 1; i <= MAX_FLAGS_PER_SPAN; i++) {
+    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, i === 3]);
   }
-  for (let i = 4; i <= MAX_FLAGS_PER_SPAN; i++) {
-    expectedOuterSpanFlags.push([`flag.evaluation.feat${i}`, false]);
-  }
-  expectedOuterSpanFlags.push(['flag.evaluation.feat3', true]);
-  expect(outerSpanFlags).toEqual(expectedOuterSpanFlags);
+  // Order agnostic (attribute dict is unordered).
+  expect(outerSpanFlags.sort()).toEqual(expectedOuterSpanFlags.sort());
 });

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans-domexception-details/init.js

@@ -0,0 +1,58 @@
+import * as Sentry from '@sentry/browser';
+
+// Create measures BEFORE SDK initializes
+
+// Create a measure with detail
+const measure = performance.measure('restricted-test-measure', {
+  start: performance.now(),
+  end: performance.now() + 1,
+  detail: { test: 'initial-value' },
+});
+
+// Simulate Firefox's permission denial by overriding the detail getter
+// This mimics the actual Firefox behavior where accessing detail throws
+Object.defineProperty(measure, 'detail', {
+  get() {
+    throw new DOMException('Permission denied to access object', 'SecurityError');
+  },
+  configurable: false,
+  enumerable: true,
+});
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  integrations: [
+    Sentry.browserTracingIntegration({
+      idleTimeout: 9000,
+    }),
+  ],
+  tracesSampleRate: 1,
+});
+
+// Also create a normal measure to ensure SDK still works
+performance.measure('normal-measure', {
+  start: performance.now(),
+  end: performance.now() + 50,
+  detail: 'this-should-work',
+});
+
+// Create a measure with complex detail object
+performance.measure('complex-detail-measure', {
+  start: performance.now(),
+  end: performance.now() + 25,
+  detail: {
+    nested: {
+      array: [1, 2, 3],
+      object: {
+        key: 'value',
+      },
+    },
+    metadata: {
+      type: 'test',
+      version: '1.0',
+      tags: ['complex', 'nested', 'object'],
+    },
+  },
+});