Skip to content

ref(vue): Clarify Vue tracing #16487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2025
Merged

ref(vue): Clarify Vue tracing #16487

merged 6 commits into from
Jun 5, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jun 5, 2025

Adds some clarifying comments and changes variable naming to make it easier to understand and parse.

@s1gr1d s1gr1d requested review from Lms24 and andreiborza June 5, 2025 07:54
Copy link
Contributor

github-actions bot commented Jun 5, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 38.34 kB - -
@sentry/browser (incl. Tracing, Replay) 76.48 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.59 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.24 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.32 kB - -
@sentry/browser (incl. Feedback) 40.73 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 40.33 kB - -
@sentry/vue 28.36 kB +0.06% +16 B 🔺
@sentry/vue (incl. Tracing) 40.19 kB +0.04% +13 B 🔺
@sentry/svelte 24.01 kB - -
CDN Bundle 25.48 kB - -
CDN Bundle (incl. Tracing) 38.52 kB - -
CDN Bundle (incl. Tracing, Replay) 74.38 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 79.8 kB - -
CDN Bundle - uncompressed 74.41 kB - -
CDN Bundle (incl. Tracing) - uncompressed 114.07 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 228.04 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.87 kB - -
@sentry/nextjs (client) 42 kB - -
@sentry/sveltekit (client) 38.84 kB - -
@sentry/node 150.28 kB - -
@sentry/node - without tracing 98.33 kB - -
@sentry/aws-serverless 124.1 kB - -

View base workflow run

@s1gr1d s1gr1d force-pushed the sig/vue-tracing-refactor branch from cbca3d0 to 8ed0151 Compare June 5, 2025 09:39
@s1gr1d s1gr1d changed the base branch from develop to sig/vue-tracing-tests June 5, 2025 09:40
@s1gr1d s1gr1d marked this pull request as ready for review June 5, 2025 09:40
Base automatically changed from sig/vue-tracing-tests to develop June 5, 2025 10:19
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great refactor! Makes the code much easier to understand!

@s1gr1d s1gr1d merged commit 0a7b915 into develop Jun 5, 2025
36 checks passed
@s1gr1d s1gr1d deleted the sig/vue-tracing-refactor branch June 5, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants