meta(changelog): Update changelog for 9.26.0#16480
Merged
andreiborza merged 6 commits intomasterfrom Jun 4, 2025
Merged
Conversation
[Gitflow] Merge master into develop
…l build mode (#16410) Next.js v15.3.0-canary.1 introduced a new approach to the two-phase experimental build (--experimental-build-mode=compile then =generate) that applies env inlining during generate build mode. Why it breaks? Our `withSentryConfig` still assumes a single “full” build and reruns its Webpack instrumentation in both phases. During the generate step it collides with Next.js’s new inliner (e.g. for assetPrefix), producing malformed JS and build failures. Root cause: Double application of build-time transforms—Sentry inlines/reprocesses a bundle that Next.js’s generate mode is simultaneously trying to finalize—leads to conflicting replacements and syntax errors. This PR is a quick workaround that patches our build script so that: 1. Compile phase (--experimental-build-mode=compile): Sentry’s instrumentation runs as usual. 2. Generate phase (--experimental-build-mode=generate): We skip Sentry’s build-time hooks entirely, letting Next.js handle inlining and prerendering without collision. This immediately prevents the build failures and defers full “generate” work to Next.js’s own pipeline. I confirmed that source maps and error / tracing still function as expected, BUT things might still occur as it's still an experimental undocumented feature. --------- Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Re-exports functionality from the `@sentry/react`. However, not everything is exported as the react router exports would be confusing. closes #16459
…ttpInstrumentation doesn't crash (#16473) On Node > 22.10.0, when spans are off, the `SentryHttpInstrumentation` attempts adding `sentry-trace` and `baggage` headers to requests. Due to race-conditions, this can error in cases where the request was already sent/finished prior to setting the headers. This fix prevents this by wrapping the logic in a try/catch. Fixes: #16438
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
prepare-release/9.26.0
branch
from
5c1a791 to
4c26495
Compare
chargome
approved these changes
Jun 4, 2025
CHANGELOG.md
Outdated
| - feat(react-router): Re-export functions from `@sentry/react` ([#16465](https://github.com/getsentry/sentry-javascript/pull/16465)) | ||
| - fix(nextjs): Skip re instrumentating on generate phase of experimental build mode ([#16410](https://github.com/getsentry/sentry-javascript/pull/16410)) | ||
| - fix(node): Ensure adding sentry-trace and baggage headers via SentryHttpInstrumentation doesn't crash ([#16473](https://github.com/getsentry/sentry-javascript/pull/16473)) | ||
| - deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478)) |
Member
There was a problem hiding this comment.
Suggested change
| - deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478)) |
I think we can skip this one
andreiborza
force-pushed
the
prepare-release/9.26.0
branch
from
4c26495 to
34989ed
Compare
andreiborza
force-pushed
the
prepare-release/9.26.0
branch
from
34989ed to
f2e28a3
Compare
Lms24
approved these changes
Jun 4, 2025
|
|
||
| ## Unreleased | ||
|
|
||
| - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott |
Member
Author
There was a problem hiding this comment.
for reference: this string is used as a detection point for our external contributor action to insert contribution attributions into the changelog automatically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.