-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta(changelog): Update changelog for 9.26.0 #16480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Gitflow] Merge master into develop
…l build mode (#16410) Next.js v15.3.0-canary.1 introduced a new approach to the two-phase experimental build (--experimental-build-mode=compile then =generate) that applies env inlining during generate build mode. Why it breaks? Our `withSentryConfig` still assumes a single “full” build and reruns its Webpack instrumentation in both phases. During the generate step it collides with Next.js’s new inliner (e.g. for assetPrefix), producing malformed JS and build failures. Root cause: Double application of build-time transforms—Sentry inlines/reprocesses a bundle that Next.js’s generate mode is simultaneously trying to finalize—leads to conflicting replacements and syntax errors. This PR is a quick workaround that patches our build script so that: 1. Compile phase (--experimental-build-mode=compile): Sentry’s instrumentation runs as usual. 2. Generate phase (--experimental-build-mode=generate): We skip Sentry’s build-time hooks entirely, letting Next.js handle inlining and prerendering without collision. This immediately prevents the build failures and defers full “generate” work to Next.js’s own pipeline. I confirmed that source maps and error / tracing still function as expected, BUT things might still occur as it's still an experimental undocumented feature. --------- Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Re-exports functionality from the `@sentry/react`. However, not everything is exported as the react router exports would be confusing. closes #16459
…ttpInstrumentation doesn't crash (#16473) On Node > 22.10.0, when spans are off, the `SentryHttpInstrumentation` attempts adding `sentry-trace` and `baggage` headers to requests. Due to race-conditions, this can error in cases where the request was already sent/finished prior to setting the headers. This fix prevents this by wrapping the logic in a try/catch. Fixes: #16438
size-limit report 📦
|
5c1a791
to
4c26495
Compare
CHANGELOG.md
Outdated
- feat(react-router): Re-export functions from `@sentry/react` ([#16465](https://github.com/getsentry/sentry-javascript/pull/16465)) | ||
- fix(nextjs): Skip re instrumentating on generate phase of experimental build mode ([#16410](https://github.com/getsentry/sentry-javascript/pull/16410)) | ||
- fix(node): Ensure adding sentry-trace and baggage headers via SentryHttpInstrumentation doesn't crash ([#16473](https://github.com/getsentry/sentry-javascript/pull/16473)) | ||
- deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478)) |
I think we can skip this one
4c26495
to
34989ed
Compare
34989ed
to
f2e28a3
Compare
@@ -1,5 +1,15 @@ | |||
# Changelog | |||
|
|||
## Unreleased | |||
|
|||
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for bringing it back :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reference: this string is used as a detection point for our external contributor action to insert contribution attributions into the changelog automatically
No description provided.