Skip to content

meta(changelog): Update changelog for 9.26.0 #16480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025

Conversation

andreiborza
Copy link
Member

No description provided.

github-actions bot and others added 4 commits June 3, 2025 14:15
[Gitflow] Merge master into develop
…l build mode (#16410)

Next.js v15.3.0-canary.1 introduced a new approach to the two-phase
experimental build (--experimental-build-mode=compile then =generate)
that applies env inlining during generate build mode.
 
Why it breaks?
Our `withSentryConfig` still assumes a single “full” build and reruns
its Webpack instrumentation in both phases. During the generate step it
collides with Next.js’s new inliner (e.g. for assetPrefix), producing
malformed JS and build failures.

Root cause: Double application of build-time transforms—Sentry
inlines/reprocesses a bundle that Next.js’s generate mode is
simultaneously trying to finalize—leads to conflicting replacements and
syntax errors.

This PR is a quick workaround that patches our build script so that:
1. Compile phase (--experimental-build-mode=compile): Sentry’s
instrumentation runs as usual.
2. Generate phase (--experimental-build-mode=generate): We skip Sentry’s
build-time hooks entirely, letting Next.js handle inlining and
prerendering without collision.

This immediately prevents the build failures and defers full “generate”
work to Next.js’s own pipeline. I confirmed that source maps and error /
tracing still function as expected, BUT things might still occur as it's
still an experimental undocumented feature.

---------

Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Re-exports functionality from the `@sentry/react`. However, not
everything is exported as the react router exports would be confusing.

closes #16459
…ttpInstrumentation doesn't crash (#16473)

On Node > 22.10.0, when spans are off, the `SentryHttpInstrumentation`
attempts adding `sentry-trace` and `baggage` headers to requests. Due to
race-conditions, this can error in cases where the request was already
sent/finished prior to setting the headers.

This fix prevents this by wrapping the logic in a try/catch.

Fixes: #16438
Copy link
Contributor

github-actions bot commented Jun 4, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB added added
@sentry/browser - with treeshaking flags 23.76 kB added added
@sentry/browser (incl. Tracing) 38.34 kB added added
@sentry/browser (incl. Tracing, Replay) 76.48 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.59 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 81.24 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 93.32 kB added added
@sentry/browser (incl. Feedback) 40.73 kB added added
@sentry/browser (incl. sendFeedback) 28.7 kB added added
@sentry/browser (incl. FeedbackAsync) 33.59 kB added added
@sentry/react 25.76 kB added added
@sentry/react (incl. Tracing) 40.33 kB added added
@sentry/vue 28.34 kB added added
@sentry/vue (incl. Tracing) 40.18 kB added added
@sentry/svelte 24.01 kB added added
CDN Bundle 25.48 kB added added
CDN Bundle (incl. Tracing) 38.52 kB added added
CDN Bundle (incl. Tracing, Replay) 74.38 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 79.8 kB added added
CDN Bundle - uncompressed 74.41 kB added added
CDN Bundle (incl. Tracing) - uncompressed 114.07 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 228.04 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.87 kB added added
@sentry/nextjs (client) 42 kB added added
@sentry/sveltekit (client) 38.84 kB added added
@sentry/node 150.08 kB added added
@sentry/node - without tracing 98.33 kB added added
@sentry/aws-serverless 124.1 kB added added

@andreiborza andreiborza requested a review from Lms24 June 4, 2025 10:11
@andreiborza andreiborza force-pushed the prepare-release/9.26.0 branch from 5c1a791 to 4c26495 Compare June 4, 2025 11:03
CHANGELOG.md Outdated
- feat(react-router): Re-export functions from `@sentry/react` ([#16465](https://github.com/getsentry/sentry-javascript/pull/16465))
- fix(nextjs): Skip re instrumentating on generate phase of experimental build mode ([#16410](https://github.com/getsentry/sentry-javascript/pull/16410))
- fix(node): Ensure adding sentry-trace and baggage headers via SentryHttpInstrumentation doesn't crash ([#16473](https://github.com/getsentry/sentry-javascript/pull/16473))
- deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- deps(react-router): Bump react-router version ([#16478](https://github.com/getsentry/sentry-javascript/pull/16478))

I think we can skip this one

@andreiborza andreiborza force-pushed the prepare-release/9.26.0 branch from 4c26495 to 34989ed Compare June 4, 2025 11:07
@andreiborza andreiborza force-pushed the prepare-release/9.26.0 branch from 34989ed to f2e28a3 Compare June 4, 2025 11:14
@@ -1,5 +1,15 @@
# Changelog

## Unreleased

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bringing it back :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference: this string is used as a detection point for our external contributor action to insert contribution attributions into the changelog automatically

@andreiborza andreiborza merged commit 89b00f6 into master Jun 4, 2025
159 checks passed
@andreiborza andreiborza deleted the prepare-release/9.26.0 branch June 4, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants