fix(opentelemetry): Ensure withScope keeps span active & _getTraceInfoFromScope works
#16385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure that `withScope(scope, callback)` maintains the active span from the passed in scope.
mydea
force-pushed
the
fn/fix-node-get-trace-info-from-scope
branch
from
4863dec to
4f36293
Compare
size-limit report 📦
|
AbhiPrasad
approved these changes
May 26, 2025
|
Going to merge this in so that I can open a PR to add more tests for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure that
withScope(scope, callback)maintains the active span from the passed in scope.Fixes #16361
The problem here was that we used the
_getSpanForScopemethod in core for this, but this only actually works for the core implementation, not the node one 😬 So I rewrote this to use more general utilities, which should work isomorphically. While doing this, I noticed an actual bug in thewithScopeimplementation in otel, where we did not actually keep the active span correctly.