Skip to content

fix(node): Fix vercel flushing logic & add test for it #16208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented May 6, 2025

As pre-work for #16178, actually add a test for this (kind of). This showed that there was actually a fundamental flaw here, as we looked as the req not the res, oops.

@mydea mydea requested a review from lforst May 6, 2025 13:34
@mydea mydea self-assigned this May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.34 KB - -
@sentry/browser - with treeshaking flags 23.16 KB - -
@sentry/browser (incl. Tracing) 37.22 KB - -
@sentry/browser (incl. Tracing, Replay) 74.45 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.32 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 79.11 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.93 KB - -
@sentry/browser (incl. Feedback) 39.72 KB - -
@sentry/browser (incl. sendFeedback) 27.96 KB - -
@sentry/browser (incl. FeedbackAsync) 32.72 KB - -
@sentry/react 25.14 KB - -
@sentry/react (incl. Tracing) 39.22 KB - -
@sentry/vue 27.6 KB - -
@sentry/vue (incl. Tracing) 38.99 KB - -
@sentry/svelte 23.36 KB - -
CDN Bundle 24.55 KB - -
CDN Bundle (incl. Tracing) 37.3 KB - -
CDN Bundle (incl. Tracing, Replay) 72.34 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.62 KB - -
CDN Bundle - uncompressed 71.62 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.34 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.63 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.15 KB - -
@sentry/nextjs (client) 40.83 KB - -
@sentry/sveltekit (client) 37.72 KB - -
@sentry/node 144.31 KB +0.04% +53 B 🔺
@sentry/node - without tracing 96.19 KB +0.06% +56 B 🔺
@sentry/aws-serverless 120.56 KB +0.05% +60 B 🔺

View base workflow run

@mydea mydea merged commit b74f300 into develop May 6, 2025
109 checks passed
@mydea mydea deleted the fn/vercel-flush-test branch May 6, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants