Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(feedback) Allowing annotation via highlighting & masking (#15484)" #15609

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Mar 6, 2025

This reverts commit 9c1f79b.

Screenshots without annotations were not showing up properly (they are being capture as completely transparent).

@billyvg billyvg marked this pull request as ready for review March 6, 2025 16:22
@billyvg billyvg requested a review from a team as a code owner March 6, 2025 16:22
Copy link
Contributor

github-actions bot commented Mar 6, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.14 KB - -
@sentry/browser - with treeshaking flags 22.93 KB - -
@sentry/browser (incl. Tracing) 36.2 KB - -
@sentry/browser (incl. Tracing, Replay) 73.38 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.79 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 78 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.56 KB +0.73% +664 B 🔺
@sentry/browser (incl. Feedback) 40.29 KB +1.58% +638 B 🔺
@sentry/browser (incl. sendFeedback) 27.78 KB +0.03% +7 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.57 KB +0.06% +18 B 🔺
@sentry/react 24.96 KB - -
@sentry/react (incl. Tracing) 38.09 KB - -
@sentry/vue 27.38 KB - -
@sentry/vue (incl. Tracing) 37.89 KB - -
@sentry/svelte 23.17 KB - -
CDN Bundle 24.35 KB - -
CDN Bundle (incl. Tracing) 36.25 KB - -
CDN Bundle (incl. Tracing, Replay) 71.26 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.43 KB +0.03% +16 B 🔺
CDN Bundle - uncompressed 71.14 KB - -
CDN Bundle (incl. Tracing) - uncompressed 107.52 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.79 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.36 KB +0.02% +31 B 🔺
@sentry/nextjs (client) 39.26 KB - -
@sentry/sveltekit (client) 36.62 KB - -
@sentry/node 142.14 KB - -
@sentry/node - without tracing 95.57 KB +0.01% +1 B 🔺
@sentry/aws-serverless 119.92 KB -0.01% -1 B 🔽

View base workflow run

@billyvg billyvg requested a review from ryan953 March 6, 2025 16:37
@billyvg billyvg merged commit 8d9f523 into develop Mar 6, 2025
158 checks passed
@billyvg billyvg deleted the revert-image-annotations branch March 6, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants