Skip to content

test(react-router): Add basic e2e test #15369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 12, 2025
Merged

test(react-router): Add basic e2e test #15369

merged 8 commits into from
Feb 12, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Feb 11, 2025

Adds a basic react-router framework test to our e2e suite.

Note that the test still contains several todos that will get fixed along the way of creating this package.

So the test currently just covers the functionality as is, not what what we want it to be.

closes #15187

@chargome chargome self-assigned this Feb 11, 2025
@chargome chargome marked this pull request as ready for review February 12, 2025 13:58
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
I think it's good to have the stuff that needs to be added after support for it is available pointed out as todo.

@chargome chargome merged commit 6227c13 into develop Feb 12, 2025
128 checks passed
@chargome chargome deleted the cg/rr-e2e-app branch February 12, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RR7] Add basic e2e testing app
2 participants