meta: Update CHANGELOG for 8.40.0 #14408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14331) Using a proper URL-based setup in browser integration tests instead of serving from a file makes the tests more realistic, as chrome behavior can differ slightly in those scenarios. I refactored any tests that required actual changes in a previous PR, so this PR does: 1. Search-replace all usages of `getLocalTestPath` with `getLocalTestUrl` 2. Remove the `getLocalTestPath` test fixture
…merged (#14315) We keep `normalizedRequest` with data like headers, urls etc. on the `sdkProcessingMetadata` on the scope. While this generally works, there are some _potential_ pitfalls/footguns there: One, if you put some (e.g. partial) `normalizedRequest` on the _current_ scope, it will just overwrite the full `normalizedRequest` from the _isolation_ scope, where generally we'll try to put the request data automatically (e.g. in the http instrumentation). Think this example: ```js Sentry.withScope(scope => { scope.setSdkProcessingMetadata({ normalizedRequest: { headers: moreSpecificHeaders } }); }); ``` the resulting event inside of this `withScope` callback would _only_ have the headers, but would miss e.g. url etc. data set. This PR changes this so that the `normalizedRequest` is merged between the types of scopes, so only set fields on e.g. the current scope will overwrite the same fields on the isolation scope, instead of just overwriting the whole normalizedRequest that results. Note that bundle size for browser is sadly anyhow affected (no matter if we go with a/b/c), as the code to merge it between scopes is always shared :(
…es (#14356) This fixes an issue with sucrase build output where it adds `__self` and `__source` attributes to DOM nodes. This seems to [only affect JSX](https://github.com/alangpierce/sucrase#jsx-options), which AFAIK only the feedback package uses.
[Gitflow] Merge master into develop
…14305) The request data integration prefers this over `request`, we want to get rid of `request` in v9. Updates the following: - [x] astro/src/server/middleware.ts - [x] bun/src/integrations/bunserver.ts - [x] cloudflare/src/scope-utils.ts - [ ] google-cloud-serverless/src/gcpfunction/http.ts - [x] nextjs/src/common/captureRequestError.ts - [x] nextjs/src/common/withServerActionInstrumentation.ts - [x] nextjs/src/common/wrapGenerationFunctionWithSentry.ts - [ ] nextjs/src/common/wrapMiddlewareWithSentry.ts - [x] nextjs/src/common/wrapRouteHandlerWithSentry.ts - [x] nextjs/src/common/wrapServerComponentWithSentry.ts - [ ] nextjs/src/common/pages-router-instrumentation/_error.ts - [ ] nextjs/src/common/pages-router-instrumentation/wrapApiHandlerWithSentry.ts - [ ] nextjs/src/common/utils/wrapperUtils.ts - [x] nextjs/src/edge/wrapApiHandlerWithSentry.ts - [ ] remix/src/utils/errors.ts - [ ] remix/src/utils/instrumentServer.ts - [x] sveltekit/src/server/handle.ts Part of #14298
…`SentryGlobalGenericFilter`, `SentryGlobalGraphQLFilter` (#14371)
…n favor of using `@sentry/nestjs` (#14374)
When running tests for the monorepo locally, replay tests can hang/may not resolve because we run them in watch mode by default. You can still use `yarn test:watch` if you want watch mode anyhow. We use `vitest run` everywhere else we have vitest already.
This PR adds a guard to avoid us throwing if we try to fill a readonly property on an object. Generally speaking this should not work, but it does not hurt us to be defensive here and try-catch this to avoid breaking users apps. Fixes #14368
…4401) This includes exporting `httpRequestToRequestEventData` from `@sentry/node`, which we can reuse in a few places. This also allows us to remove a bunch of stuff from remix, because actually we can just use `winterCGRequestToRequestData` instead of the custom implementation we have there. at least type wise, this should all work, let's see if any test complains... Closes #14298
Add support for the new major version by bumping peer dependencies and adding an Angular 19 e2e test app.
andreiborza
approved these changes
Nov 21, 2024
mydea
approved these changes
Nov 21, 2024
AbhiPrasad
approved these changes
Nov 21, 2024
| }; | ||
| ``` | ||
|
|
||
| - **feat(core): Deprecate `debugIntegration` and `sessionTimingIntegration` ([#14363](https://github.com/getsentry/sentry-javascript/pull/14363))** |
There was a problem hiding this comment.
I realize we should have identified these earlier, but we should add these as entries to MIGRATION.md. We can do it as a follow-up.
There was a problem hiding this comment.
Looks like they are mentioned in the v9 migration guide draft:
sentry-javascript/docs/migration/draft-v9-migration-guide.md
Lines 11 to 15 in 26f9db8
Should we just add these entries to MIGRATION.md? Might also be fair to wait a bit longer and do it when everything is scoped out for v9.
There was a problem hiding this comment.
Considering they can be changed with the release now, IMO we should reference them in the main migration guide.
Adds `loadTime` and `renderTime` attributes from the [LCP performance entry](https://developer.mozilla.org/en-US/docs/Web/API/LargestContentfulPaint#instance_properties) to the `pageload` span. Besides being valuable information for users, this also helps us detect if LCP is potentially unreliable: If the LCP element was from a 3rd party origin and the `Timing-Allow-Origin` header was not sent in the resource response, the `renderTime` will be `0`.
Lms24
force-pushed
the
prepare-release/8.40.0
branch
from
8520d16 to
fb7a363
Compare
robinvw1
added a commit
to robinvw1/sentry-javascript
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.