fix(nuxt): Don't restrict source map assets upload #13800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Sep 25, 2024
packages/nuxt/src/vite/sourceMaps.ts
Outdated
| @@ -60,7 +60,7 @@ function normalizePath(path: string): string { | |||
|
|
|||
| function getPluginOptions( | |||
| moduleOptions: SentryNuxtModuleOptions, | |||
| isNitro = false, | |||
| _isNitro = false, | |||
There was a problem hiding this comment.
l: do we still need this param? If not, let's remove it
packages/nuxt/src/vite/sourceMaps.ts
Outdated
| assets: | ||
| sourceMapsUploadOptions.sourcemaps?.assets ?? isNitro ? ['./.output/server/**/*'] : ['./.output/public/**/*'], | ||
| // The server/client files are in different places depending on the nitro preset (e.g. '.output/server' or '.netlify/functions-internal/server' | ||
| // We cannot determine automatically how the build folder looks like (depends on the preset), so we have to accept that sourcemaps are generated multiple times (with Vite for Nuxt and Rollup for Nitro). |
There was a problem hiding this comment.
l: just to clarify for me from our convo yesterday: What we have to live with is that some source maps might be uploaded multiple times. They shouldn't be generated by the bundlers more than once, right?
Suggested change
| // We cannot determine automatically how the build folder looks like (depends on the preset), so we have to accept that sourcemaps are generated multiple times (with Vite for Nuxt and Rollup for Nitro). | |
| // We cannot determine automatically how the build folder looks like (depends on the preset), so we have to accept that sourcemaps are uploaded multiple times (with Vite for Nuxt and Rollup for Nitro). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source maps generated by Vite are only for the Nuxt-part of the application whereas source maps generated by Rollup are only for the Nitro-part of the application. The Nuxt-part of the application has some overlap with the Nitro-part and so it would be nice to specify the client/server folder in the
assetsoption, but the output is different for every Nitro preset (the files are always located under a different path).Should fix #13703