fix(nuxt): Use correct server output file path #13725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig/build-output-path-correction
branch
from
e8ee328 to
7813a0a
Compare
Lms24
approved these changes
Sep 19, 2024
andreiborza
reviewed
Sep 19, 2024
| const rootDirResolver = createResolver(nuxt.options.rootDir); | ||
| nitro.hooks.hook('close', async () => { | ||
| const rootDirResolver = createResolver(nitro.options.rootDir); | ||
| const serverDirResolver = createResolver(nitro.options.output.serverDir); | ||
| const source = rootDirResolver.resolve('.nuxt/dist/server/sentry.server.config.mjs'); |
There was a problem hiding this comment.
In SolidStart, I can get the build directory via nitro.options.buildDir, does Nuxt's nitro config not have that exposed?
Sadly not, as the setup in the E2E test is still with the file in the public folder (the nft resolution did not work in the package.json). But I'll try to fix that problem in another PR. Edit: Just tried it but our setup somehow confuses pnpm and the override/resolution is ignored. The version of nft is always 0.26 (not 0.27) in the lock file For this PR, I tested every preset manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the nitro preset, the build output changes. By using the
serverDiroption, the directory can be retrieved dynamically.