Skip to content

Conversation

@nicohrubec
Copy link
Member

@nicohrubec nicohrubec commented Jul 31, 2024

Adds automatic instrumentation to @sentry/nestjs. Guards in nest have a @Injectable decorator and implement a canActivate function. So we can simply extend the existing instrumentation to add a proxy for canActivate.

Also fixed a mistake with the middleware instrumentation (missing return).

Screenshot from sample app:
Screenshot 2024-07-31 at 13 03 12

@nicohrubec nicohrubec linked an issue Jul 31, 2024 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024

size-limit report 📦

Path Size
@sentry/browser 22.45 KB (0%)
@sentry/browser (incl. Tracing) 34.22 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.62 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.26 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.11 KB (0%)
@sentry/browser (incl. metrics) 26.75 KB (0%)
@sentry/browser (incl. Feedback) 39.37 KB (0%)
@sentry/browser (incl. sendFeedback) 27.06 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.7 KB (0%)
@sentry/react 25.22 KB (0%)
@sentry/react (incl. Tracing) 37.22 KB (0%)
@sentry/vue 26.6 KB (0%)
@sentry/vue (incl. Tracing) 36.06 KB (0%)
@sentry/svelte 22.58 KB (0%)
CDN Bundle 23.64 KB (0%)
CDN Bundle (incl. Tracing) 35.88 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.57 KB (0%)
CDN Bundle - uncompressed 69.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.16 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.99 KB (0%)
@sentry/nextjs (client) 37.07 KB (-0.04% 🔽)
@sentry/sveltekit (client) 34.79 KB (-0.06% 🔽)
@sentry/node 114.65 KB (+0.09% 🔺)
@sentry/node - without tracing 89.33 KB (-0.01% 🔽)
@sentry/aws-serverless 98.5 KB (0%)

@nicohrubec nicohrubec marked this pull request as ready for review July 31, 2024 11:11
@nicohrubec nicohrubec requested review from Lms24, lforst and mydea July 31, 2024 11:13
@nicohrubec nicohrubec merged commit e2668f8 into develop Jul 31, 2024
@nicohrubec nicohrubec deleted the nh/instrument-nest-guards branch July 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instrumentation of NestJS guards

3 participants