Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered #12973

Conversation

jaspreet57
Copy link
Contributor

Fixing a missing paranthesis to call appendToDom on DOMContentLoaded event.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #12970

@jaspreet57 jaspreet57 requested a review from a team as a code owner July 18, 2024 08:20
@jaspreet57 jaspreet57 force-pushed the feedback/fix-feedback-integration-init-setup branch from ce5bcc7 to c1d8efe Compare July 18, 2024 08:45
@andreiborza andreiborza self-requested a review July 18, 2024 09:19
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@andreiborza andreiborza merged commit 1619efc into getsentry:develop Jul 18, 2024
111 checks passed
andreiborza added a commit that referenced this pull request Jul 18, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #12973

---------

Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Feedback] Feedback button is not attached to DOM, when it is initialized while DOCUMENT is still loading
2 participants