feat(nestjs): Filter 4xx errors #12695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally lgtm, would you mind adding an E2E test? |
|
@lforst sure, will take a look |
mydea
reviewed
Jul 1, 2024
Comment on lines
14
to
16
| console.log("UNEXPECTED EXCEPTION"); | ||
| console.log(errorEvent); | ||
|
|
There was a problem hiding this comment.
Suggested change
| console.log("UNEXPECTED EXCEPTION"); | |
| console.log(errorEvent); |
Comment on lines
45
to
47
| console.log("EXPECTED EXCEPTION"); | ||
| console.log(errorEvent); | ||
|
|
There was a problem hiding this comment.
Suggested change
| console.log("EXPECTED EXCEPTION"); | |
| console.log(errorEvent); |
I guess a leftover of debugging? :D
There was a problem hiding this comment.
Yes! Sorry the test was not done yet, I just pushed for debugging. Should have put it back into draft mode :)
lforst
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change filtering expected errors from being reported to sentry in the nestjs sdk.
Tested manually on my sample app.
Fixes #12523