Skip to content

fix(bundle): Ensure CDN bundles do not overwrite window.Sentry #12580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 20, 2024

v8 portion of #12579 (not that relevant there because no Loader support yet, but still...)

@mydea mydea requested review from lforst and AbhiPrasad June 20, 2024 12:45
@mydea mydea self-assigned this Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (added)
@sentry/browser (incl. Tracing) 33.31 KB (added)
@sentry/browser (incl. Tracing, Replay) 69.09 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.41 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.14 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.34 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.2 KB (added)
@sentry/browser (incl. metrics) 26.5 KB (added)
@sentry/browser (incl. Feedback) 38.45 KB (added)
@sentry/browser (incl. sendFeedback) 26.85 KB (added)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (added)
@sentry/react 24.96 KB (added)
@sentry/react (incl. Tracing) 36.35 KB (added)
@sentry/vue 26.32 KB (added)
@sentry/vue (incl. Tracing) 35.16 KB (added)
@sentry/svelte 22.35 KB (added)
CDN Bundle 23.42 KB (added)
CDN Bundle (incl. Tracing) 35.05 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.17 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.38 KB (added)
CDN Bundle - uncompressed 68.78 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 103.63 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.1 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.77 KB (added)
@sentry/nextjs (client) 36.23 KB (added)
@sentry/sveltekit (client) 33.95 KB (added)
@sentry/node 112.99 KB (added)
@sentry/node - without tracing 90.39 KB (added)
@sentry/aws-serverless 99.48 KB (added)

@mydea mydea force-pushed the fn/fix-cdn-bundle-v8 branch from 5fcd94e to 07ab474 Compare June 21, 2024 07:35
@mydea mydea merged commit 6e07ec7 into develop Jun 21, 2024
98 checks passed
@mydea mydea deleted the fn/fix-cdn-bundle-v8 branch June 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants