feat(redis): Add cache logic for redis-4 #12429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Jun 10, 2024
| return createClient().connect(); | ||
| } | ||
|
|
||
| let client; |
There was a problem hiding this comment.
l: Can we rename this (and the method below) to e.g. redisClient? Can be a bit confusing otherwise as we also have a sentry client :)
mydea
reviewed
Jun 10, 2024
|
|
||
| const spanDescription = safeKey.join(', '); | ||
|
|
||
| span.updateName(spanDescription.length > 1024 ? `${spanDescription.substring(0, 1024)}...` : spanDescription); |
There was a problem hiding this comment.
BTW, I just remembered we have a truncate method in utils, we should probably use this here!
mydea
approved these changes
Jun 10, 2024
s1gr1d
force-pushed
the
sig/add-redis-4-integration
branch
from
8f338e4 to
38ef208
Compare
mydea
reviewed
Jun 10, 2024
| @@ -17,6 +20,7 @@ import { | |||
| getCacheOperation, | |||
| shouldConsiderForCache, | |||
| } from '../../utils/redisCache'; | |||
| import { truncate } from '@sentry/utils/src'; | |||
There was a problem hiding this comment.
this import is not correct, should not have the /src part (this probably comes from the editor...)
size-limit report 📦
|
mydea
approved these changes
Jun 10, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up as cache logic for
iorediswas already added.