feat(solidjs): Add e2e tests #12328
Merged
feat(solidjs): Add e2e tests #12328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Jun 3, 2024
| }, | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "@playwright/test": "^1.43.1", |
There was a problem hiding this comment.
Suggested change
| "@playwright/test": "^1.43.1", | |
| "@playwright/test": "^1.44.1", |
let's use latest here!
There was a problem hiding this comment.
ah, and also add @sentry-internal/test-utils as a dep, explicitly.
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
reviewed
Jun 3, 2024
| }); | ||
|
|
||
| test('sends a navigation transaction', async ({ page }) => { | ||
| page.on('console', msg => console.log(msg.text())); |
There was a problem hiding this comment.
Suggested change
| page.on('console', msg => console.log(msg.text())); |
mydea
reviewed
Jun 3, 2024
|
|
||
| test('sends a navigation transaction', async ({ page }) => { | ||
| page.on('console', msg => console.log(msg.text())); | ||
| const pageloadTxnPromise = waitForTransaction('solidjs', async transactionEvent => { |
There was a problem hiding this comment.
Actually no need to wait on this, we can just wait for the navigation only, that should be all fine! Just go to / and then navigate, should always emit a navgiation span either way.
mydea
reviewed
Jun 3, 2024
| // transactions with the proper name once the `useLocation` hook triggers. | ||
| page.on('console', msg => console.log(msg.text())); | ||
|
|
||
| const pageloadTxnPromise = waitForTransaction('solidjs', async transactionEvent => { |
There was a problem hiding this comment.
same here, no need to wait on pageload (we need to wait on the first navigation, to ensure that we test the correct thing afterwards)
size-limit report 📦
|
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.