fix(feedback): Override TriggerLabel Option #12316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
May 31, 2024
| @@ -252,7 +252,7 @@ export const buildFeedbackIntegration = ({ | |||
|
|
|||
| const _createActor = (optionOverrides: OverrideFeedbackConfiguration = {}): ActorComponent => { | |||
| const shadow = _createShadow(_options); | |||
| const actor = Actor({ triggerLabel: _options.triggerLabel, shadow }); | |||
| const actor = Actor({ triggerLabel: optionOverrides.triggerLabel || _options.triggerLabel, shadow }); | |||
There was a problem hiding this comment.
I would split and reorder mergedOptions below so that we have:
- merged options of
_optionsandoptionOverrides - pass a new object of merged options + the actor callbacks to
_attachTo
Then we can use the merged options for creating a shadow + actor so that we can avoid this type of issue in the future where the wrong options are used.
billyvg
approved these changes
May 31, 2024
c298lee
added a commit
that referenced
this pull request
Jun 4, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12229