Skip to content

fix(replay): Avoid infinite loop of logs #12309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(replay): Avoid infinite loop of logs #12309

merged 1 commit into from
May 31, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 31, 2024

When using _experiments.traceInternals, this could lead to an infinite loop, as we run this check when a breadcrumb is added, and we add this breadcrumb in the check, ...

Fixes #12283

@mydea mydea requested a review from billyvg May 31, 2024 09:31
@mydea mydea self-assigned this May 31, 2024
@mydea mydea requested a review from a team as a code owner May 31, 2024 09:31
When using `_experiments.traceInternals`, this could lead to an infinite loop, as we run this check when a breadcrumb is added, and we add this breadcrumb in the check, ...
@mydea mydea force-pushed the fn/replay-guard branch from b753b5d to 77fad49 Compare May 31, 2024 09:44
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.74 KB (0%)
@sentry/browser (incl. Tracing) 32.76 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) 68.33 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.64 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.39 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.5 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.35 KB (+0.04% 🔺)
@sentry/browser (incl. metrics) 25.92 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) 37.9 KB (0%)
@sentry/browser (incl. sendFeedback) 26.32 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.86 KB (0%)
@sentry/react 24.51 KB (0%)
@sentry/react (incl. Tracing) 35.8 KB (+0.07% 🔺)
@sentry/vue 25.73 KB (+0.02% 🔺)
@sentry/vue (incl. Tracing) 34.59 KB (+0.08% 🔺)
@sentry/svelte 21.87 KB (0%)
CDN Bundle 23.11 KB (0%)
CDN Bundle (incl. Tracing) 34.5 KB (+0.12% 🔺)
CDN Bundle (incl. Tracing, Replay) 68.42 KB (+0.05% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.6 KB (+0.05% 🔺)
CDN Bundle - uncompressed 68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 102.16 KB (+0.06% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212.05 KB (+0.03% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.52 KB (+0.03% 🔺)
@sentry/nextjs (client) 35.14 KB (+0.06% 🔺)
@sentry/sveltekit (client) 33.39 KB (+0.08% 🔺)
@sentry/node 115.24 KB (-0.01% 🔽)
@sentry/aws-serverless 103.73 KB (+0.01% 🔺)

@mydea mydea merged commit 5dd4c63 into develop May 31, 2024
77 checks passed
@mydea mydea deleted the fn/replay-guard branch May 31, 2024 12:32
c298lee pushed a commit that referenced this pull request Jun 4, 2024
When using `_experiments.traceInternals`, this could lead to an infinite
loop, as we run this check when a breadcrumb is added, and we add this
breadcrumb in the check, ...

Fixes #12283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalError: too much recursion
3 participants