fix(feedback): Wait for document to be ready before doing autoinject #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
May 30, 2024
billyvg
approved these changes
May 30, 2024
c298lee
approved these changes
May 30, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error that folks are getting is something like this:
[Error] TypeError: null is not an object (evaluating 'qo.body.appendChild')The problem seems to be that we're trying to inject the button into the html before the
<body>is ready. Using async<script defer>or<script async>would probably help, but none of our snippets have that, and it would also defer error observers and everything else.What we can do for users it have the feedback integration wait before inserting the button + styles!
This is a great reference: https://developer.mozilla.org/en-US/docs/Web/API/Document/DOMContentLoaded_event
Fixes #12112