Skip to content

ref(react): Use WeakSet to keep track of navigation instrumented clients #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

andreiborza
Copy link
Member

This came up in the review for solidjs but is also applicable to react.

@andreiborza andreiborza requested review from mydea, lforst and Lms24 May 29, 2024 08:49
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.73 KB (0%)
@sentry/browser (incl. Tracing) 32.76 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.63 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.25 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.32 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.13 KB (0%)
@sentry/browser (incl. metrics) 25.9 KB (0%)
@sentry/browser (incl. Feedback) 37.74 KB (0%)
@sentry/browser (incl. sendFeedback) 26.31 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.73 KB (0%)
@sentry/react 24.45 KB (0%)
@sentry/react (incl. Tracing) 35.78 KB (+0.02% 🔺)
@sentry/vue 25.71 KB (0%)
@sentry/vue (incl. Tracing) 34.58 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 23.06 KB (0%)
CDN Bundle (incl. Tracing) 34.48 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.31 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.31 KB (0%)
CDN Bundle - uncompressed 68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 102.1 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.37 KB (0%)
@sentry/nextjs (client) 35.12 KB (0%)
@sentry/sveltekit (client) 33.37 KB (0%)
@sentry/node 114.66 KB (0%)
@sentry/aws-serverless 103.37 KB (0%)

@andreiborza andreiborza merged commit c3b66fa into develop May 29, 2024
85 checks passed
@andreiborza andreiborza deleted the ab/react-router-client-weakset branch May 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants