fix(aws): Ensure lambda layer uses default export from ImportInTheMiddle
#12233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mydea
reviewed
May 27, 2024
| @@ -124,7 +140,7 @@ export function makeBaseBundleConfig(options) { | |||
| const bundleTypeConfigMap = { | |||
| standalone: standAloneBundleConfig, | |||
| addon: addOnBundleConfig, | |||
| node: nodeBundleConfig, | |||
There was a problem hiding this comment.
Is node not used anywhere else? Nice!
There was a problem hiding this comment.
Nope, the only thing we bundled with this config on the node side is the aws lambda layer bundle
mydea
approved these changes
May 27, 2024
Lms24
changed the title
ImportInTheMiddleImportInTheMiddle
AbhiPrasad
reviewed
May 27, 2024
Yes, my plan is to add an e2e test that more or less does exactly what our layer would do. Taking a look at this right now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is a fun one:
Our lambda layer relies on one bundled Sentry SDK, which caused problems raised in #12089 and #12009 (comment). Specifically, by bundling
import-in-the-middlecode into one file, it seems like the library's way of declaring its exports conflict, causing the "ImportInTheMiddle is not a constructor" error to be thrown. While this should ideally be fixed soon inimport-in-the-middle, for now this PR adds a small Rollup plugin to transformnew ImportInTheMiddle(...)calls tonew ImportInTheMiddle.default(...)to our AWS Lambda Layer bundle config.Once the fixes land upstream and we updated our dependencies accordingly, we should remove this plugin again.
I tested this locally with a reproduction that failed with the exact same error message as reported in #12089. We should add an e2e test that tests the layer (as well as the AWS Serverless SDK). I'm gonna take a look at this today and open a follow up PR.
For now, this (in combination with #12232) hopefully
fixes #12089