fix: Only import inspector asynchronously
#12231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
approved these changes
May 27, 2024
|
Just converted back to a draft because I'm going to try add a test for this so it doesn't regress again! |
timfish
force-pushed
the
timfish/fix-import-inspector
branch
from
a44e99b to
197d9a5
Compare
AbhiPrasad
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12223
I've added a test that uses
import-in-the-middleto throw ifinspectoris imported without enabling theLocalVariablesintegration so this should not regress in the future.Note that we don't need to import asynchronously in the worker scripts since these are not evaluated if the features aren't used.