fix(node): Fix nest.js error handler #11874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was brought up here #5578 (comment),
our error handler implementation was too naive, and our tests not ideal - the tests only checked that stuff is sent to sentry (which it was!) but not that the page otherwise worked.
Now, I updated the test to ensure this works as expected.
With this PR, the signature for
Sentry.setupNestErrorHandler()
changes ( breaking change, but sadly required at this point). You have to pass in an exception filter, which we'll extend to also send exceptions to Sentry:This is a bit more involved, but also allows you to use a custom filter if needed (we can extend any exception filter).