Skip to content

ref(v8): Remove addRequestDataToTransaction util #11369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2024

See #11368, where this is deprecated on v7.

@mydea mydea requested review from lforst and AbhiPrasad April 2, 2024 11:18
@mydea mydea self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Bundle Report

Changes will decrease total bundle size by 3.33MB ⬇️

Bundle name Size Change
@sentry/vercel-edge-cjs 18.23kB 0 bytes
@sentry/vercel-edge-esm 16.13kB 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry/node-esm (removed) 333.56kB ⬇️
@sentry-internal/replay-esm (removed) 306.46kB ⬇️
@sentry-internal/node-integration-tests-cjs (removed) 1.04kB ⬇️
@sentry/node-cjs (removed) 336.97kB ⬇️
@sentry/opentelemetry-cjs (removed) 68.45kB ⬇️
@sentry/utils-cjs (removed) 178.75kB ⬇️
@sentry/bun-cjs (removed) 13.5kB ⬇️
@sentry-internal/replay-canvas-cjs (removed) 29.51kB ⬇️
@sentry-internal/replay-cjs (removed) 306.35kB ⬇️
@sentry/wasm-cjs (removed) 5.2kB ⬇️
@sentry-internal/feedback-esm (removed) 65.5kB ⬇️
@sentry/bun-esm (removed) 10.05kB ⬇️
@sentry/astro-cjs (removed) 27.13kB ⬇️
@sentry/aws-serverless-cjs (removed) 14.62kB ⬇️
@sentry/react-esm (removed) 41.18kB ⬇️
@sentry/utils-esm (removed) 174.17kB ⬇️
@sentry-internal/tracing-cjs (removed) 108.01kB ⬇️
@sentry/svelte-cjs (removed) 13.84kB ⬇️
@sentry-internal/replay-canvas-esm (removed) 29.43kB ⬇️
@sentry/sveltekit-cjs (removed) 69.31kB ⬇️
@sentry/vue-cjs (removed) 20.19kB ⬇️
@sentry/google-cloud-serverless-cjs (removed) 23.0kB ⬇️
@sentry/sveltekit-esm (removed) 61.08kB ⬇️
@sentry/wasm-esm (removed) 4.85kB ⬇️
@sentry/remix-cjs (removed) 53.62kB ⬇️
@sentry/astro-esm (removed) 23.39kB ⬇️
@sentry/remix-esm (removed) 48.23kB ⬇️
@sentry/opentelemetry-esm (removed) 67.4kB ⬇️
@sentry/gatsby-esm (removed) 385 bytes ⬇️
@sentry/gatsby-cjs (removed) 905 bytes ⬇️
@sentry-internal/node-integration-tests-esm (removed) 888 bytes ⬇️
@sentry/vue-esm (removed) 18.85kB ⬇️
@sentry-internal/tracing-esm (removed) 107.26kB ⬇️
@sentry/profiling-node-cjs (removed) 25.5kB ⬇️
@sentry/profiling-node-esm (removed) 25.52kB ⬇️
@sentry/browser-cjs (removed) 107.36kB ⬇️
@sentry/core-cjs (removed) 240.44kB ⬇️
@sentry/google-cloud-serverless-esm (removed) 19.16kB ⬇️
@sentry/core-esm (removed) 236.82kB ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry/browser-esm (removed) 104.53kB ⬇️

@mydea mydea force-pushed the fn/remove-addRequestDataToTransaction branch from 4e181e8 to b0cd603 Compare April 2, 2024 11:59
@AbhiPrasad
Copy link
Member

Gonna merge this in so I can remove span.attributes!

@AbhiPrasad AbhiPrasad merged commit feab8af into develop Apr 2, 2024
@AbhiPrasad AbhiPrasad deleted the fn/remove-addRequestDataToTransaction branch April 2, 2024 15:11
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants