-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Unify code style using Prettier and updates ESLint rules #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HazAT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to point out the parameters we use for sentry itself.
https://github.com/getsentry/sentry/blob/master/src/sentry/lint/engine.py#L184-L190
We probably don't need the jsx option but we should at least consider having the same options for all ours repos.
|
But other than that, nice job 👍 |
|
Agree. We should also consider removing ESLint rules that are touching anything related to code style, as they might clash with Prettier. For example by using https://github.com/prettier/eslint-config-prettier |
It allows us to use eslint-disable-next-line clause and use parentheses in logical values with prettier
|
@HazAT all updated. Same changes are reflected in getsentry/raven-node#364
|
|
😱 |
This PR includes:
package.jsonfile, so it's almost exactly the same asraven-nodeone (missingauthorfield)prettiersetup withhusky, so it runs for every file that's about to be commitedgrunt-eslint, which allows us to useeslint-disable-next-lineclause (prettier moveseslint-disable-lineclauses to the line below, which breaks it's functionality)lintscript topackage.jsonNotes:
Related
raven-nodePR: getsentry/raven-node#364