RavenJS triggers deprecations from jQuery Migrate

[romainneutron]

jQuery team provides a tool called jQuery Migrate to ease migration from version to version. It's especially a nice tool when migrating from jQuery 1/2 to jQuery 3.

However, when using jQuery migrate and RavenJS, deprecations are triggered by this code https://github.com/getsentry/raven-js/blob/master/src/raven.js#L927-L934

        var $ = _window.jQuery || _window.$;
        if ($ && $.fn && $.fn.ready) {
            fill($.fn, 'ready', function (orig) {
                return function (fn) {
                    return orig.call(this, self.wrap(fn));
                };
            }, wrappedBuiltIns);
        }

[mattrobenolt]

It's unclear to me how this is a problem for us. We're intending to monkey patch jQuery, but we'd need to support any version of jQuery. Everything here is guarded and should be safe between any of these versions, so I don't see what we would need to do here.

[tacman]

Possibly related, but honestly I can't tell if this is a raven issue or raven reporting an issue from somewhere else.

JQMIGRATE: Migrate is installed with logging active, version 3.0.0
raven.js:80 JQMIGRATE: jQuery.unique is deprecated, use jQuery.uniqueSorta.(anonymous function) @ raven.js:80
jquery-migrate.js:64console.tracec @ jquery-migrate.js:64

[benvinegar]

@tacman – for breadcrumbs Raven.js overrides console.log which causes log statements to appear to come from Raven.js. It definitely does not use jQuery.unique, so I suspect the deprecation notice is being triggered by somewhere in your own code / other library.

[tacman]

Thanks, Ben. That makes sense, we'll check it out.

…

On Mon, Feb 6, 2017 at 3:57 PM, Ben Vinegar ***@***.***> wrote: @tacman <https://github.com/tacman> – for breadcrumbs Raven.js overrides console.log which causes log statements to appear to come from Raven.js. It definitely does not use jQuery.unique, so I suspect the deprecation notice is being triggered by somewhere in your own code / other library. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#817 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAl0QbqJkZ0WeJNhuAcj3Z8Wnk2gfsoxks5rZ4kkgaJpZM4LcyP2> .

[benvinegar]

@romainneutron – I think we'll just remove this code, it serves less and less purpose today.